Skip to content

Add Japanese data - #209

Open
shama7gupta wants to merge 2 commits into
mainfrom
add-japanese-data
Open

Add Japanese data#209
shama7gupta wants to merge 2 commits into
mainfrom
add-japanese-data

Conversation

@shama7gupta

Copy link
Copy Markdown
Collaborator

Adds japanese data to medical_hr, itsm, and airline domains.

@tiffanyannedo tiffanyannedo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding suggestions to the JA set. Translations have been verified and committed directly to the branch

"ja": [
"アルファガレージ",
"アルファ駐車場",
"メイン駐車場"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shama7gupta , can I add more to this list? If so, here are others I would consider: "メイン"ガレージ", "本館ガレージ", "メイン車庫"

"ダウンタウン",
"ダウンタウンビル",
"営業本部",
"都心オフィス"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If adding other natural ways to say: "都心", "セールス本部", "都心事務所"

"ja": [
"ダウンタウン",
"ダウンタウンオフィス",
"人事本部",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also adding on: "都心事務所", "財務部"

"ja": [
"イーストガレージ",
"東キャンパス駐車場",
"東駐車場"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one isn't natural. Should get rid of 東駐車場

"주차장 a"
],
"ja": [
"エー駐車場",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one isn't natural either, A would be the suffic in JA. Should get rid of エー駐車場

"북측 주차장"
],
"ja": [
"ガレージエー",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like 'garage a' and 'main garage' is used in a number of garage selections. Not sure if this is wanted?

"ja": [
"北側平面駐車場",
"北駐車場",
"本社北駐車場"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would also add "本部北駐車場"

"운영 센터"
],
"ja": [
"オペセン",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would remove this. It is too colloquial and I do not see any anyone using this when talking to a voice agent. They would only use "オペレーションセンター" that is already listed below

"ja": [
"リバーサイド",
"リバーサイド技術センター",
"技術センター"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also other options would be: "エンジニアリングセンター", "リバーサイドエンジニアリングセンター"

Comment thread data/airline_dataset.json
"first_name": "美穂",
"last_name": "渡辺",
"companion": {
"first_name": "佑樹",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shama7gupta In Japan it is not customary for spouses to share a last name or for the wife to take on the husband's last name. It would be more realistic if there is also a last_name field for the companion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants